Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response counts bug in pipeline runner #904

Merged
merged 8 commits into from
Mar 21, 2025
Merged

Conversation

bkorycki
Copy link
Contributor

I added some unit tests for the pipeline runners and also fixed the bug that caused overcounting of sut responses in the metadata.

@bkorycki bkorycki requested a review from a team as a code owner March 20, 2025 21:12
@bkorycki bkorycki temporarily deployed to Scheduled Testing March 20, 2025 21:12 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing March 20, 2025 21:12 — with GitHub Actions Inactive
@bkorycki bkorycki temporarily deployed to Scheduled Testing March 20, 2025 21:12 — with GitHub Actions Inactive
@bkorycki bkorycki requested review from wpietri and rogthefrog March 20, 2025 21:12
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@wpietri wpietri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, you are not messing around with the tests. Love to see it.

Copy link
Collaborator

@dhosterman dhosterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkorycki bkorycki merged commit 5fa4457 into main Mar 21, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants