Skip to content

chore: make iOS app build work with Xcode 16.4+ #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

chore: make iOS app build work with Xcode 16.4+ #1065

wants to merge 12 commits into from

Conversation

@anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Oct 20, 2025 •
edited
Loading

Changes:

@anhappdev
Add zlib and libpng dependencies with BUILD files
c11bd12 
- Add minimal BUILD file for zlib and libpng under `third_party`.
- Override zlib and libpng as http_archive dependencies in WORKSPACE.
- Update zlib and libpng versions for Xcode 16.4 compatibility.
@anhappdev anhappdev requested a review from a team as a code owner October 20, 2025 11:43
@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev anhappdev marked this pull request as draft October 20, 2025 11:47
@anhappdev anhappdev changed the title chore: override zlib and libpng dependencies for Xcode 16.4 chore: build iOS app with Xcode 16.4 Oct 20, 2025
@anhappdev anhappdev changed the title chore: build iOS app with Xcode 16.4 chore: build iOS app with Xcode 16.4+ Oct 21, 2025
@anhappdev
Copy link
Collaborator Author

  • The build runs successfully on Xcode 16.4 and Xcode 26.0.1,
  • It runs successfully on macOS 15.6 but not on macOS 26.0 (due to a clang error mentioned here).

@anhappdev anhappdev changed the title chore: build iOS app with Xcode 16.4+ chore: make iOS app build work with Xcode 16.4+ Oct 23, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anhappdev anhappdev marked this pull request as ready for review October 24, 2025 12:31
@anhappdev
Copy link
Collaborator Author

@freedomtan Currently, the iOS build in Xcode Cloud on the master branch fails because Xcode 16.2 is no longer supported. To address this issue, I propose merging this PR first to provide a fix for the newer Xcode version. In another PR, I will ensure that the build works with macOS 26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build the App with macOS 26.0 and Xcode 26.0 Build iOS app with the iOS 18 SDK or later

1 participant

@anhappdev