Skip to content

Compiler: Arbitrary Instances + Property Test #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 10, 2023
Merged

Compiler: Arbitrary Instances + Property Test #34

merged 14 commits into from
Feb 10, 2023

Conversation

cstml
Copy link
Contributor

@cstml cstml commented Feb 1, 2023 •
edited
Loading

  • Add Arbitrary instances to the ProtoCompat types.
  • Add 1 Property test to the kind checker.

@cstml cstml marked this pull request as draft February 1, 2023 10:14
@cstml cstml self-assigned this Feb 1, 2023
@cstml cstml added the compiler Work related to the Lambda Buffers Compiler label Feb 1, 2023
@cstml cstml added this to the Catalyst milestone 2 milestone Feb 1, 2023
@cstml cstml force-pushed the compiler/arbitrary-instances branch from ee6f766 to a179797 Compare February 1, 2023 11:56
@cstml cstml force-pushed the compiler/arbitrary-instances branch from a179797 to 0223834 Compare February 1, 2023 11:57
@cstml cstml marked this pull request as ready for review February 1, 2023 11:58
@cstml cstml requested a review from bladyjoker February 1, 2023 11:58
@cstml cstml marked this pull request as draft February 1, 2023 15:11
@cstml cstml changed the title Compiler: Arbitrary Instances Compiler: Arbitrary Instances + Propert Test Feb 1, 2023
@cstml cstml changed the title Compiler: Arbitrary Instances + Propert Test Compiler: Arbitrary Instances + Property Test Feb 1, 2023
@cstml cstml force-pushed the compiler/arbitrary-instances branch from 4ac24d5 to a38170a Compare February 1, 2023 15:53
Base automatically changed from compiler/integrate-CLI-KindChecker to main February 8, 2023 10:40
@cstml cstml marked this pull request as ready for review February 8, 2023 12:57
bladyjoker
bladyjoker reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits for ya!

A general topic tho is where to place Arbitrary instances, I prefer all arbitraries orphaned in a separate module thus keeping the type defs clean and the Arbitrary instance colocated (convenient because the gen patterns are usually similar).

@cstml cstml force-pushed the compiler/arbitrary-instances branch from c0aaa2f to a448d57 Compare February 9, 2023 17:48
@bladyjoker bladyjoker merged commit 419f3a9 into main Feb 10, 2023
@bladyjoker bladyjoker deleted the compiler/arbitrary-instances branch February 10, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bladyjoker bladyjoker bladyjoker approved these changes

Assignees

@cstml cstml

Labels
compiler Work related to the Lambda Buffers Compiler
Projects
Lambda Buffers
Status: Done
Milestone
Catalyst milestone 2: End to end proo...
Development

Successfully merging this pull request may close these issues.
2 participants
@cstml @bladyjoker