MonadUnify #47
Open
MonadUnify #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianBalaj
requested changes
Feb 19, 2025
| @@ -95,13 +102,14 @@ library | |||
| Covenant.Internal.TyExpr | |||
|
|
|||
| build-depends: | |||
| QuickCheck ==2.15.0.1, | |||
| QuickCheck, | |||
There was a problem hiding this comment.
Why dropping the QuickCheck constraints?
src/Control/Monad/Unify.hs
Outdated
| -- Helper for querying the state of a variable. It can either be fresh | ||
| -- (`Nothing`), bound to a definition (`Just . Left`) or part of an equivalence | ||
| -- class without a definition (`Just . Right`). | ||
| definedAs :: |
There was a problem hiding this comment.
Hmm, maybe we could use a custom sum type instead of Either so it's more expressive? 🤔
There was a problem hiding this comment.
Maybe even the Maybe could be replaced with something more specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MicroKanren-style unification as a capability monad, together with a basic concrete stack that implements it. This is a necessary prerequisite to #41.
@KristianBalaj and @itsfarseen - please let me know if this requires more documentation to explain how it works. There's potentially a lot of complexity here, and some of the choices are somewhat unique to our situation, so it might benefit from clarification. Also, more laws are definitely needed, but I couldn't think of any others.