adopt mlx 0.29.1 and related mlx-c #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Sep 24, 2025
| "mlx/mlx/backend/metal/no_metal.cpp", | ||
|
|
||
| // special handling for cuda -- we need to keep one file: | ||
| // mlx/mlx/backend/cuda/no_cuda.cpp |
There was a problem hiding this comment.
This is a little more complicated than I wish, but we can't exclude the directory + include one file, so I need to just list them.
davidkoski
commented
Sep 24, 2025
| /// - ``asArray(_:)`` | ||
| /// - ``asData(access:)`` | ||
| public func asMTLBuffer(device: any MTLDevice, noCopy: Bool = false) -> (any MTLBuffer)? { | ||
| let data = asData(access: noCopy ? .noCopyIfContiguous : .copy) |
There was a problem hiding this comment.
From #259 -- this line is unused.
davidkoski
commented
Sep 24, 2025
|
|
||
| // If it's just a simple slice, just do a slice update and return | ||
| if operations.count == 1, case let .slice(slice) = operations[0] { | ||
| if operations.count == 1, case .slice(let slice) = operations[0] { |
There was a problem hiding this comment.
Just the new swift-format.
davidkoski
commented
Sep 24, 2025
| /// - values: values with shape `[B, N_kv, T_kv, D]` | ||
| /// - scale: scale for queries, typically `1 / sqrt(q.dim(-1))` | ||
| /// - mask: mask array | ||
| /// - sinks: optional array of attention sinks |
There was a problem hiding this comment.
New optional argument
davidkoski
commented
Sep 24, 2025
| } | ||
|
|
||
| let x = MLXArray(1) | ||
| let x = MLXArray([1]) |
There was a problem hiding this comment.
This was incorrect before -- a dimensionless parameter is not the same as a shaped array. Now it throws as the back end rejects it.
This was referenced Sep 26, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needed: