add dilation parameter to convolution layers (match mlx.nn) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Jan 17, 2025
| @@ -15,6 +15,7 @@ open class Conv1d: Module, UnaryLayer { | |||
| public let weight: MLXArray | |||
| public let bias: MLXArray? | |||
| public let padding: Int | |||
| public let dilation: Int | |||
There was a problem hiding this comment.
Adding dilation parameter to match python (mlx.nn)
davidkoski
commented
Jan 17, 2025
| /// - bias: if `true` add a learnable bias to the output | ||
| public init( | ||
| inputChannels: Int, | ||
| outputChannels: Int, | ||
| kernelSize: IntOrTriple, | ||
| stride: IntOrTriple = 1, | ||
| padding: IntOrTriple = 0, | ||
| dilation: IntOrTriple = 1, |
There was a problem hiding this comment.
Curiously the mlx.nn version doesn't have dilation on Conv3d -- oversight or is this omitted for a reason?
There was a problem hiding this comment.
Thanks for checking! That looks like an oversight. I will add it.
awni
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.