Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct handling of no-image case for qwen2-vl #179

Merged
merged 1 commit into from
Jan 27, 2025
Merged

correct handling of no-image case for qwen2-vl #179

merged 1 commit into from
Jan 27, 2025

Conversation

davidkoski
Copy link
Collaborator

@davidkoski davidkoski requested a review from awni January 14, 2025 18:39
davidkoski
davidkoski commented Jan 14, 2025
View reviewed changes
Libraries/MLXVLM/Models/Qwen2VL.swift
@@ -783,7 +783,7 @@ public class Qwen2VL: Module, VLMModel, KVCacheDimensionProvider {
-> MLXArray
{
guard let pixelValues, let gridThw else {
return languageModel(inputIds).logits
return languageModel.model.embedTokens(inputIds[.newAxis, .ellipsis])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blaizzy/mlx-vlm#94

awni
awni approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@davidkoski davidkoski merged commit 4b67a79 into main Jan 27, 2025
1 check passed
@davidkoski davidkoski deleted the vlm-no-image branch January 27, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text-only prompts don't work for VLMs
2 participants
@davidkoski @awni