Skip to content

Conversation

bswck
Copy link
Member

@bswck bswck commented Sep 17, 2025

Closes #407

For reviewers

  • I did not use AI
  • I used AI and thorougly reviewed every code/docs change

I think I'll just remove the section with the checkbox about AI in my future PRs lol

@pawamoy
Copy link
Member

pawamoy commented Sep 17, 2025

I think I'll just remove the section with the checkbox about AI in my future PRs lol

Yes, this privilege has been granted to you many moons ago.

@bswck bswck force-pushed the b/fix-namespace-packages-from-json branch 6 times, most recently from 6e3b13d to c11704f Compare September 18, 2025 01:42
@pawamoy
Copy link
Member

pawamoy commented Sep 18, 2025

Looking good, just need a small test and we're good to go.

@bswck
Copy link
Member Author

bswck commented Sep 18, 2025

Yeah, I did 5071560 and c11704f to check for any sensible places near where I could put a test.

@bswck bswck force-pushed the b/fix-namespace-packages-from-json branch from da9224b to 68c3ab6 Compare September 18, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: from_json seems to be broken
2 participants