Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented persistent reorder todo list functionality #15

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

Steinvall
Copy link

@Steinvall Steinvall commented Oct 31, 2024

  • Addresses this issue

  • Frontend: Added “react-beautiful-dnd” for drag and drop functionality on the todo list

  • Backend: Added “order” attribute on TodoItem entity and added backend API “/reorder” to persist changes across different clients/browsers (even if it’s just an in-memory database at the moment)

@mblomdahl

@mblomdahl mblomdahl requested a review from okaziya November 1, 2024 07:35
Copy link
Member

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully from my testing! Great job @Steinvall! 🙃

backend/src/todo-service.js Outdated Show resolved Hide resolved
backend/src/todo-item.js Outdated Show resolved Hide resolved
frontend/package.json Show resolved Hide resolved
@Steinvall
Copy link
Author

Please merge this pull request at your convenience @mblomdahl (I can't since I don't have write access to the repository). Unless there is something else you want me to change/fix, of course.

@mblomdahl mblomdahl merged commit 733a53e into mkdevops-se:master Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants