Clangfixes #26
Open
Clangfixes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make clang compiler happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues that arose when building with clang on OSX. Changes include:
Allowing definition of NO_OPENMP to disable OpenMP support without messing with the Makefile
Fixed what appears to be an obvious incorrect use of && instead of & in Cube::IsEdgeCorner
Added braces with nested ifs to make logic clear and eliminate compiler warnings.
Add ifdef in MinimalAreaTriangulation::GetTriangulation to suppress compiler warning for possible tautology.
Replaced _data.size() with _sz in DenseNodeData::index() since _data.size() may be unsupported depending on array debug/template instantiation.
My editor also removes trailing space from lines when I write files, so there are a bunch of changes removing those.