Skip to content

Commit

Permalink
feat: update react, typescript rules (#23)
Browse files Browse the repository at this point in the history
  • Loading branch information
leohxj authored Sep 1, 2019
1 parent e4b94d5 commit 112ecc9
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 7 deletions.
5 changes: 3 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# by default, .eslintrc will ignored
!.eslintrc.js
# by default, dotfile will ignored by eslint
# we unignore them to be linted
!.*

# build assets should not lint
dist/
3 changes: 2 additions & 1 deletion packages/eslint-config/overrides/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ module.exports = {
react: require('./react'),
mdx: require('./mdx'),
recommended: [
require('./typescript'),
require('./babel'),
require('./typescript'),
require('./react'),
require('./jest'),
require('./mdx'),
],
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/plugins/babel.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// eslint-plugin-babel has no recommend config
// https://github.com/babel/eslint-plugin-babel
module.exports = {
extends: ['prettier/babel'],
parser: 'babel-eslint',
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config/plugins/import.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// https://github.com/benmosher/eslint-plugin-import
module.exports = {
plugins: ['import'],
rules: {
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config/plugins/markdown.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// https://github.com/rx-ts/eslint-mdx/tree/master/packages/eslint-plugin-mdx
module.exports = {
extends: ['plugin:mdx/recommended'],
overrides: [
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config/plugins/react-hooks.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// https://www.npmjs.com/package/eslint-plugin-react-hooks
module.exports = {
plugins: ['react-hooks'],
rules: {
Expand Down
9 changes: 7 additions & 2 deletions packages/eslint-config/plugins/react.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
// https://github.com/yannickcr/eslint-plugin-react#recommended
module.exports = {
extends: ['prettier/react'],
plugins: ['react'],
extends: ['plugin:react/recommended', 'prettier/react'],
rules: {},
settings: {
react: {
version: 'detect',
},
},
};
10 changes: 9 additions & 1 deletion packages/eslint-config/plugins/typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,20 @@ module.exports = {
'plugin:import/typescript',
'prettier/@typescript-eslint',
],
rules: {},
rules: {
'@typescript-eslint/explicit-function-return-type': 0,
},
parserOptions: {
project: fs.existsSync(ESLINT_TSCONFIG)
? ESLINT_TSCONFIG
: fs.existsSync(BASE_TSCONFIG)
? BASE_TSCONFIG
: require.resolve('@mjolnir/tsconfig'),
},
settings: {
// shared settings for eslint-plugin-node
node: {
tryExtensions: ['.js', '.jsx', '.json', '.ts', '.tsx'],
},
},
};

0 comments on commit 112ecc9

Please sign in to comment.