Updated the event value and added numberOfButtons as per ST documentation - #2
Open
ady624 wants to merge 4 commits into
Open
Updated the event value and added numberOfButtons as per ST documentation#2ady624 wants to merge 4 commits into
ady624 wants to merge 4 commits into
Conversation
Modified to allow for correct event value "pushed" and added numberOfButtons as per ST documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation requires that the event value in case of a button push is "pushed". Original code sends "button X" instead. Button number is sent in the data Map, using the buttonNumber parameter. That was correctly implemented. Also added the numberOfButtons attribute.
Documentation here: http://docs.smartthings.com/en/latest/capabilities-reference.html#button