Merge pull request #13979 from ronso0/controller-sett-clickable-check…

…box-label

Controller settings: have clickable checkbox label (like QCheckBox)

src/controllers/legacycontrollersettings.cpp

@@ -5,6 +5,7 @@
 #include <QCheckBox>
 #include <QComboBox>
 #include <QDoubleSpinBox>
+#include <QEvent>
 #include <QLabel>
 #include <QLayout>
 #include <QSpinBox>
@@ -150,9 +151,15 @@ QWidget* LegacyControllerBooleanSetting::buildInputWidget(QWidget* pParent) {
         emit changed();
     });
 
+    // We want to format the checkbox label with html styles. This is not possible
+    // so we attach a separate QLabel and, in order to get a clickable label like
+    // with QCheckBox, we associate the label with the checkbox (buddy).
+    // When the label is clicked we toggle the checkbox in eventFilter().
     auto pLabelWidget = make_parented<QLabel>(pWidget);
     pLabelWidget->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Maximum);
     pLabelWidget->setText(label());
+    pLabelWidget->setBuddy(pCheckBox);
+    pLabelWidget->installEventFilter(this);
 
     QBoxLayout* pLayout = new QHBoxLayout();
 
@@ -174,6 +181,17 @@ bool LegacyControllerBooleanSetting::match(const QDomElement& element) {
                     Qt::CaseInsensitive) == 0;
 }
 
+bool LegacyControllerBooleanSetting::eventFilter(QObject* pObj, QEvent* pEvent) {
+    QLabel* pLabel = qobject_cast<QLabel*>(pObj);
+    if (pLabel && pEvent->type() == QEvent::MouseButtonPress) {
+        QCheckBox* pCheckBox = qobject_cast<QCheckBox*>(pLabel->buddy());
+        if (pCheckBox) {
+            pCheckBox->toggle();
+        }
+    }
+    return QObject::eventFilter(pObj, pEvent);
+}
+
 template<class SettingType,
         Serializer<SettingType> ValueSerializer,
         Deserializer<SettingType> ValueDeserializer,

src/controllers/legacycontrollersettings.h

@@ -136,6 +136,8 @@ class LegacyControllerBooleanSetting
                     LegacyControllerSettingsLayoutContainer::HORIZONTAL)
             override;
 
+    bool eventFilter(QObject* pObj, QEvent* pEvent) override;
+
     QJSValue value() const override {
         return QJSValue(m_savedValue);
     }