Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commercial fixes, CI tests, more tests, coverage #883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kidev
Copy link
Contributor

@Kidev Kidev commented Jan 29, 2025

  • Fixes issues with clashing auth method in commercial calls
  • Add a file dedicated to commercial testing
  • Add CI tests
  • Improve coverage

WIP

Note: I think my auto-format is not well configured for .sh files, I'll fix to not overwrite lines I did not touch for nothing

Copy link

gitguardian bot commented Jan 29, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Kidev
Copy link
Contributor Author

Kidev commented Jan 29, 2025

I'm replacing email and password by env vars TEST_EMAIL TEST_PASSWORD. @miurahr You'll need to create a Qt account (you only need a throwaway email and a password for it to work), and setup Action secrets AQT_TEST_EMAIL AQT_TEST_PASSWORD (from here). The rest should work then (did it on my PR repo). This prevents the storage and sharing of plain credentials, even if phony.

In the mean time, some tests related to commercial will fail on this PR

@Kidev Kidev mentioned this pull request Jan 30, 2025
@Kidev Kidev force-pushed the commercial_fix_and_tests branch from a04d595 to a95763d Compare January 30, 2025 16:51
@Kidev Kidev force-pushed the commercial_fix_and_tests branch from a95763d to 654ec42 Compare January 30, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant