fix potential erroneous handling of extension data. #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ArchiveDownloadError was raised: 1. on the first pass through the loop an error could occur "UnboundLocalError: cannot access local variable 'extensions_xml_text' where it is not associated with a value" 2. on subsequent passes the previous value of extensions_xml_text could be reused inappropriately. Also use QtRepoProperty.known_extensions for improved maintainability, i.e. the list of possible extensions is only defined in one place.
|
This comment is irrelevant to this issue. |
|
I still working on the test. Feel free to close this PR and go with #868 if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ArchiveDownloadError was raised:
cannot access local variable 'extensions_xml_text' where it is not
associated with a value"
be reused inappropriately.
Also use QtRepoProperty.known_extensions for improved maintainability,
i.e. the list of possible extensions is only defined in one place.