Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aqt/combinations.json #751

Closed
wants to merge 0 commits into from
Closed

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 1, 2024

The ci/generate_combinations.py script has detected changes to the repo at https://download.qt.io.
This PR will update aqt/combinations.json to account for those changes.

Posted from the check_combinations action

@miurahr
Copy link
Owner

miurahr commented Feb 4, 2024

This removes many entries rather than just adding 6.7.0. Why?

@ddalcino
Copy link
Contributor

ddalcino commented Feb 9, 2024

This removes many entries rather than just adding 6.7.0. Why?

Missing architectures:

The relevant code is on line 45:

def iter_arches() -> Generator[dict, None, None]:
logger.info("Fetching arches")
archive_ids = list(iter_archive_ids(category="qt"))
for archive_id in tqdm(archive_ids):
for version in ("latest", "5.15.2", "5.13.2", "5.9.9"):
for arch_name in MetadataFactory(archive_id, architectures_ver=version).getList():
yield {
"os_name": archive_id.host,
"target": archive_id.target,
"arch": arch_name,
}

To make sure these runs don't take too long, we are only checking for architectures in the latest version of Qt6 and a couple versions of Qt5. Currently, the latest Qt6 is 6.7.0, which is in Beta2 right now, planned to release on March 19. I don't know why Qt 6.7.0 is missing those extra architectures right now, but I'm guessing they will come back sometime before the final release.

It would probably make a lot of sense to fetch data for more than one version of Qt6; I vote for the LTS versions (6.2 and 6.5).

Missing modules for Qt 6.7.0:

We are hard-coding the module checks to check Linux, using architecture=gcc_64:

def iter_modules_for_qt_minor_groups(
host: str = "linux", target: str = "desktop", arch: str = "gcc_64"
) -> Generator[Dict, None, None]:
logger.info("Fetching qt modules for {}/{}".format(host, target))
for major, minor in tqdm(list(iter_qt_minor_groups(host, target))):
yield {
"qt_version": f"{major}.{minor}",
"modules": MetadataFactory(
ArchiveId("qt", host, target), modules_query=MetadataFactory.ModulesQuery(f"{major}.{minor}.0", arch)
).getList(),
}

Qt 6.7.0 for linux does not have a gcc_64; it has been replaced with linux_gcc_64, so the function doesn't return any modules for that version of Qt.

@miurahr
Copy link
Owner

miurahr commented Feb 9, 2024

OK, I'd like to try adding 6.2 and 6.5. Also try to make it recognizing gcc_64 and linux_gcc_64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants