Skip to content

Conversation

@wmww
Copy link

@wmww wmww commented Jul 20, 2025

Fixes #289 by making MD_MARK_tag a union (so the compiler will give it the correct alignment). Since the main member of the union is an anonymous struct, its properties can still be accessed as if they're toplevel MD_MARK_tag properties.

@N-R-K
Copy link

N-R-K commented Jul 20, 2025

Both the store and load are done via memcpy - which works at byte level - and thus there's no alignment issues. Whatever tool you're using is giving false positive warning.

@wmww
Copy link
Author

wmww commented Jul 21, 2025

I would expect it to be well defined, I suppose a false positive is a possibility. In any case I think my patch (especially now after edits) makes the code clearer, simpler and shorter as well as making it play nice with Fil-C, so maybe still worth merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alignment issue detected by Fil-C

2 participants