Differentiable Surface Interaction #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speierers
changed the title
Speierers
changed the title
Speierers
force-pushed
the
differential_si
branch
from
6008f91 to
5e5ed14
Compare
- Add Shape::ray_intersect_preliminary - Add Scene::ray_intersect_preliminary - Rename Shape::fill_surface_interaction into Shape::compute_surface_interaction - Add support for differential SurfaceInteraction3f - Add unit tests for differentiable SI - Remove Shape::normal_derivative()
Speierers
force-pushed
the
differential_si
branch
from
5e5ed14 to
e8d16ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I propose some API changes, mainly in
scene.handshape.hto add more flexibility and finer control on how theSurfaceInteraction3fis computed after ray intersection.This is the first part of a larger work itemon integrating the
pathreparamplugin from PR #157.Testing
TODO
Checklist:
gpu_*andpacket_*variants. If you can't test this, please leave a note in the description above