Add modbus scan registers ability and modbus parsers #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3vco
requested changes
Nov 21, 2025
|
|
||
| scan_results = [] | ||
|
|
||
| for func_code, read_func, max_per_request, name, output_name in func_specs: |
Contributor
There was a problem hiding this comment.
Can we break out a "find highest address" function?
Author
There was a problem hiding this comment.
Added _find_highest_address function
src/modbus/actions/spec.py
Outdated
| batch_size = min(remaining, 10) | ||
|
|
||
| success = False | ||
| while batch_size > 0 and not success: |
Contributor
There was a problem hiding this comment.
And a "read batch" function?
Contributor
There was a problem hiding this comment.
I'm going to work on a CI action to help generate these binaries
|
|
||
|
|
||
| @ModbusClient.action | ||
| def scan_modbus(self, device_id=1): |
Contributor
There was a problem hiding this comment.
Great idea for a new action and solid execution. I think it would be helpful for maintenance to split this function up a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to scan the counts of different registers and read their values. Also added modbus parsers.