Read device info #5
Merged
+88
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3vco
reviewed
Nov 21, 2025
Contributor
d3vco
left a comment
d3vco
left a comment
There was a problem hiding this comment.
This looks like a good add. Can you tell me what kind of testing you've done? I don't have access to a device that accepts the 0x2B function right now to verify that this works as intended.
Contributor
Author
|
@d3vco I tested against a Pymodbus server. Specifically, the remote IO we have in our GRFICSv3 project if you want to check it out! https://github.com/Fortiphyd/GRFICSv3 |
d3vco
approved these changes
Dec 1, 2025
Contributor
|
The changes look good, but the built payloads conflict and I don't have permission to edit this PR. Can you merge main back into your branch? It won't matter which payloads you keep on the conflict because I will rebuild them after accepting the PR. |
Contributor
Author
|
@d3vco ok, I think it should be good to go now |
Contributor
|
Merged! Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Read Device Information Modbus function, which is an example of T0888.