Skip to content

Conversation

@charleshu-8
Copy link
Contributor

@charleshu-8 charleshu-8 commented Jun 5, 2024

  • Add Unicode support to HTML export
  • Add Unicode support to CSV export
  • Check other exports for Unicode support

Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 added bug Something isn't working heimdall-frontend Issue is related to the Heimdall-Lite frontend labels Jun 5, 2024
@charleshu-8 charleshu-8 self-assigned this Jun 5, 2024
@charleshu-8 charleshu-8 marked this pull request as draft June 5, 2024 16:53
@charleshu-8 charleshu-8 linked an issue Jun 5, 2024 that may be closed by this pull request
@charleshu-8 charleshu-8 changed the title Add UTF-8 Support for Exports Add Unicode Support for Exports Jun 5, 2024
Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 marked this pull request as ready for review June 5, 2024 19:32
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for these exports and utf-8 characters

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@charleshu-8
Copy link
Contributor Author

Probably want to wait on #5910 and move the injected BOM to OHDF Converters side of things.

@sonarqubecloud
Copy link

@charleshu-8 charleshu-8 marked this pull request as draft July 23, 2024 17:35
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working heimdall-frontend Issue is related to the Heimdall-Lite frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] HTML and CSV exports do not support non-ascii properly

3 participants