Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
There is a buffer overflow in
printint
function which can be triggered if numbers with more than 16 digits are written to the terminal. Numbers 18446744073709551615 and -9223372036854775808 both have 20 digits for instance. To this extent, I increased the buffer size to 20 characters which can fit base 10 of all 64 bit numbers (negative or positive).I was also curious if this bug exists in x86 version of xv6. But apparently, the
printint
function used to accept anint
instead oflong long
which was only 32 bits!