Connect and listen to BOLT compatible nodes#437
Open
Varunram wants to merge 3 commits intomit-dci:masterfrom
Open
Connect and listen to BOLT compatible nodes#437Varunram wants to merge 3 commits intomit-dci:masterfrom
Varunram wants to merge 3 commits intomit-dci:masterfrom
Conversation
delbonis
added
enhancement
Collaborator
|
Should those other PRs be closed now? |
Varunram
force-pushed
the
preboltmaster
branch
from
4c764a0 to
f8a3e05
Compare
delbonis
reviewed
Dec 3, 2018
| } else if len(adr) == 0 { | ||
| // so the user didn't provide us with an address to connect to | ||
| // we need to connect to the locally running lit-af instance | ||
| lc.RPCClient, err = litrpc.NewLocalLndcRpcClientWithHomeDirAndPort(defaultDir, port) |
Collaborator
There was a problem hiding this comment.
Can we make a way to specify a homedir too? Because without that it kinda breaks my workflow.
Contributor
Author
There was a problem hiding this comment.
hm.. yeah, I think that would be possible, was possible earlier as well iirc. Will push an update.
Contributor
Author
There was a problem hiding this comment.
This seems to work right now (./lit-af --dir=blah), was this the use case you were looking at?
This was referenced Dec 5, 2018
Contributor
Author
|
retest this please |
this is a combination of earlier PRs mit-dci#434 and mit-dci#435 with newer changes. With this PR, you must be able to 1. Connect to a remote lnd node and observe connection success 2. Connect remote lnd node to lit node for 15s
Varunram
force-pushed
the
preboltmaster
branch
from
ffbfb4f to
00d4acc
Compare
Contributor
Author
|
Closed other PRs, squashed the commits in this one. |
Varunram
force-pushed
the
preboltmaster
branch
from
81f90eb to
45b5de3
Compare
Varunram
force-pushed
the
preboltmaster
branch
from
45b5de3 to
c618cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connection will be short-lived (15s), but the log statements would let you verify that you're connected. Start lnd, use getinfo and try connecting to lit's pubkey (available in lit's log).
EDIT: Rebased on current master, contains #434 and #435 within it (squashed and rebased, refer #436 for list of commits)