feat(settings): add option to toggle Keychain usage for credentials#57
Merged
Conversation
- Add guard clause in migrateLegacySecrets() to prevent Keychain access when user has disabled Keychain storage - Update documentation to reflect the new optional Keychain feature - Fix outdated code comment about secret storage location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useKeychaintoggle in Settings to allow users to choose between Keychain and UserDefaults for credential storageChanges
Core Logic
useKeychainproperty inSettingsStore(default:truefor backward compatibility)saveSecret/getSecret/deleteSecret) to route credentials based on user preferencemigrateLegacySecrets()to skip Keychain access whenuseKeychainis disabledUI
Documentation
doc/04-storage-and-settings.zh-CN.mdto document the new storage optiondoc/09-security-and-audit.zh-CN.mdto reflect the security implicationsSecurity Note
When Keychain is disabled, credentials are stored in plaintext in UserDefaults plist file. This is intended for development/testing environments or personal devices where repeated Keychain authorization is inconvenient.