fix: resolve ERR_HTTP_HEADERS_SENT and transport reuse errors#2
Open
frank-ih wants to merge 1 commit into
Open
fix: resolve ERR_HTTP_HEADERS_SENT and transport reuse errors#2frank-ih wants to merge 1 commit into
frank-ih wants to merge 1 commit into
Conversation
- Remove redundant response send in DELETE /mcp handler (StreamableHTTPServerTransport handles headers internally) - Remove manual flushHeaders/hijack in GET /mcp handler (transport manages headers) - Convert mcp-server singleton to factory pattern (creates fresh Server instance per transport connection) This fixes two recurring Chrome MCP bridge errors: 1. ERR_HTTP_HEADERS_SENT - double header send from transport + reply.send() 2. "Already connected to a transport" - singleton Server instance reuse across connections Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two recurring Chrome MCP bridge errors that have been unresolved since April 13th:
Issue 1: ERR_HTTP_HEADERS_SENT
StreamableHTTPServerTransportsends HTTP response headers twice:transport.handleRequest()which internally sends headers, then calledreply.code(NO_CONTENT).send()- causing double headersreply.raw.flushHeaders()beforetransport.handleRequest(), creating header conflictsFix: Remove manual header operations - let the transport manage all header sending.
Issue 2: "Already connected to a transport"
The MCP
Serverwas a singleton - the same instance was reused across multiple transport connections, butServer.connect()tracks transports internally and throws when reusing.Fix: Convert
mcp-server.jsfrom singleton to factory pattern - creates a freshServerinstance per transport connection.Changes
dist/server/index.jsreply.send()after transport handles requestdist/server/index.jsflushHeaders()andreply.hijack()dist/mcp/mcp-server.jsTest plan
🤖 Generated with Claude Code