Skip to content

Add some logging if cache fails to write #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paladox wants to merge 4 commits into from
+31 −4
Closed

Add some logging if cache fails to write #453

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
544739b
Add some logging if cache fails to write and also fix removing temp f…
paladox Dec 3, 2023
a627fd8
Update CreateWikiJson.php
paladox Dec 3, 2023
f4a495b
Update CreateWikiJson.php
paladox Dec 3, 2023
fee5459
Merge branch 'master' into paladox-patch-4
Universal-Omega Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions includes/CreateWikiJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use BagOStuff;
use Config;
use MediaWiki\Logger\LoggerFactory;
use MediaWiki\MediaWikiServices;
use Miraheze\CreateWiki\Hooks\CreateWikiHookRunner;
use ObjectCache;
Expand Down Expand Up @@ -268,11 +269,24 @@ private function generateDatabasesJsonFile( array $databaseLists ) {
if ( $tmpFile ) {
if ( file_put_contents( $tmpFile, json_encode( $contents ) ) ) {
if ( !rename( $tmpFile, "{$this->cacheDir}/{$name}.json" ) ) {
unlink( $tmpFile );
LoggerFactory::getInstance( 'CreateWiki' )->error(
'Database cache failure: failure to rename {name} to {newName} on disk.',
[
'name' => $tmpFile,
'newName' => "{$this->cacheDir}/{$name}.json"
]
);
}
} else {
unlink( $tmpFile );
LoggerFactory::getInstance( 'CreateWiki' )->error(
'Database cache failure: failure to write cache to disk at {name}.',
[
'name' => "{$this->cacheDir}/{$name}.json"
]
);
}

unlink( $tmpFile );
}
}
}
Expand Down Expand Up @@ -344,11 +358,24 @@ private function generateWiki() {
if ( $tmpFile ) {
if ( file_put_contents( $tmpFile, json_encode( $jsonArray ) ) ) {
if ( !rename( $tmpFile, "{$this->cacheDir}/{$this->wiki}.json" ) ) {
unlink( $tmpFile );
LoggerFactory::getInstance( 'CreateWiki' )->error(
'Wiki cache failure: failure to rename {name} to {newName} on disk.',
[
'name' => $tmpFile,
'newName' => "{$this->cacheDir}/{$this->wiki}.json"
]
);
}
} else {
unlink( $tmpFile );
LoggerFactory::getInstance( 'CreateWiki' )->error(
'Database cache failure: failure to write cache to disk at {name}.',
[
'name' => "{$this->cacheDir}/{$this->wiki}.json"
]
);
}

unlink( $tmpFile );
}
}

Expand Down