Missing record on creating new in find_entry. Fix for access logic #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access logic was flawed because if a name existed that was not banned, the IP was not checked for a ban.
SmallJoker
requested changes
Nov 2, 2025
init.lua
Outdated
Comment on lines
229
to
245
| local wl = db.whitelist or {} | ||
| if wl[name] or wl[ip] then return end | ||
|
|
||
| -- Single lookups for name and IP | ||
| local e_name = xban.find_entry(name) | ||
| local e_ip = ip and xban.find_entry(ip) | ||
|
|
||
| if (e_name and e_name.banned) or (e_ip and e_ip.banned) then | ||
| local date = | ||
| (e_name and e_name.banned and e_name.expires and os.date("%c", e_name.expires)) or | ||
| (e_ip and e_ip.banned and e_ip.expires and os.date("%c", e_ip.expires)) or "the end of time" | ||
| local reason = | ||
| (e_name and e_name.banned and e_name.reason) or | ||
| (e_ip and e_ip.banned and e_ip.reason) or "No reason given" | ||
| minetest.kick_player(name, ("Banned: Expires: %s, Reason: %s"):format(date, reason)) | ||
| return | ||
| end |
Member
There was a problem hiding this comment.
Why do you need the same code here? All players must first pass register_on_prejoinplayer, thus this is redundant.
Contributor
Author
There was a problem hiding this comment.
ah yes, flawed logic in my head. no need to check that again
init.lua
Outdated
Comment on lines
212
to
214
| local date = | ||
| (e_name and e_name.banned and e_name.expires and os.date("%c", e_name.expires)) or | ||
| (e_ip and e_ip.banned and e_ip.expires and os.date("%c", e_ip.expires)) or "the end of time" |
Member
There was a problem hiding this comment.
Code duplication. Wouldn't it be simpler to use something like this? (untested)
local e = xban.find_entry(name)
if not e or not e.banned then
-- Check if banned by IP
e = ip and xban.find_entry(ip)
end
if e and e.banned then
local date = e.expires and os.date("%c", e.expires) or "the end of time"
local reason = e.reason or "No reason given"
return ("Banned: Expires: %s, Reason: %s"):format(date, reason)
end
SmallJoker
reviewed
Nov 7, 2025
| e.names[ip] = true | ||
| end | ||
| e.last_seen = os.time() | ||
| local e = xban.find_entry(name) |
Member
There was a problem hiding this comment.
Please use tabs to indent, like used in the rest of the code.
EDIT: The same goes for xban.find_entry. I did not notice that the indent style is now mixed.
SmallJoker
reviewed
Nov 7, 2025
| end) | ||
|
|
||
| minetest.register_on_joinplayer( | ||
| function(player) |
Member
There was a problem hiding this comment.
So... no changes here? The change of indent levels makes it difficult to see differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access logic was flawed because if a name existed that was not banned, the IP was not checked for a ban.
I forgot to add the records table when creating a new entry.(Fix)