修复默认attachment翻页无效问题 #518

ljk123 · 2025-01-03T05:45:52Z

Summary by CodeRabbit

新功能
- 优化资源选择器面板的分页功能
- 改进了登录会话管理和注销流程
Bug 修复
- 修复了页面切换时资源列表获取的问题
- 优化了未授权响应的处理机制
性能优化
- 简化了 HTTP 拦截器中的注销逻辑
- 改进了分页控件的交互响应

coderabbitai · 2025-01-03T05:46:00Z

📝 Walkthrough

变更概览

步骤说明

本次变更主要涉及两个文件：web/src/components/ma-resource-picker/panel.vue 和 web/src/utils/http.ts，分别对资源选择器的分页功能和 HTTP 拦截器的注销逻辑进行了优化。

变更

文件	变更摘要
`web/src/components/ma-resource-picker/panel.vue`	新增 `handleChangePage` 函数，完善分页控制逻辑，更新资源列表获取方法
`web/src/utils/http.ts`	新增 `isLogout` 变量，重构注销处理流程，简化令牌刷新和错误处理机制

诗歌

🐰 分页兔子轻轻跳
请求如风，数据飞扬
拦截器守护登录道
错误消息悄然藏
代码如诗，优雅飞翔 🌈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or PR title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

web/src/utils/http.ts (1)
77-84: 建议避免在箭头函数中直接赋值，以提升可读性并消除 lint 告警

目前 setTimeout(() => isLogout = false, 5000) 会触发 Biome 工具的警告。可通过在回调中使用花括号来赋值，增强可读性，同时遵循无赋值表达式的最佳实践：
- setTimeout(() => isLogout = false, 5000)
+ setTimeout(() => {
+   isLogout = false
+ }, 5000)
🧰 Tools

🪛 Biome (1.9.4)

[error] 81-81: The assignment should not be in an expression.

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

(lint/suspicious/noAssignInExpressions)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c48f9fc and 13bbfff.

📒 Files selected for processing (2)

web/src/components/ma-resource-picker/panel.vue (3 hunks)
web/src/utils/http.ts (2 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

web/src/utils/http.ts

[error] 81-81: The assignment should not be in an expression.

The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.

(lint/suspicious/noAssignInExpressions)

🔇 Additional comments (4)

web/src/utils/http.ts (1)

55-56: 在全局作用域中引入共享状态需谨慎使用

isLogout 为全局变量，若在多标签或并发场景下使用，需要注意并发访问及同步问题，避免出现不一致或重复登出。建议在登出流程完成后适时进行重置或基于更细粒度的状态管理方案。

web/src/components/ma-resource-picker/panel.vue (3)

135-140: 结构化参数处理便于扩展

通过解构 params 获取 pageNo、pageSize 并合并到 queryParams，逻辑清晰且便于后期拓展其他查询参数。实现良好。

371-375: 分页事件处理函数设计合理

引入 handleChangePage 函数集中管理页码与页面大小的变更，并进行数据刷新，符合单一职责原则。

487-487: 分页组件参数映射一致

将 page-size 同步绑定到 queryParams.pageSize，与其他参数命名对齐，便于维护。

zds-s · 2025-01-03T09:27:20Z

web/src/components/ma-resource-picker/panel.vue

@@ -362,7 +368,11 @@ function executeContextmenu(e: MouseEvent, resource: Resource) {
    ],
  })
 }
-
+function handleChangePage(currentPage: number, pageSize: number) {
+  queryParams.value.pageNo = currentPage


pageNo 是什么

前端代码之前翻页标记就是pageNo 我怕直接改了影响其他用调用就在只在请求这里替换了

所有的翻页统一都用 page（当前页码） page_size (每页页数）之前是 pageNo 那应该是写错了

那等周末X.Mo提吧

ljk123 added 2 commits December 30, 2024 14:09

chore(http.ts): 优化401状态退出不用等满3秒显得很卡

64b5539

fix(ma-resource-picker)翻页无效问题

13bbfff

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 3, 2025

dosubot bot added the bug label Jan 3, 2025

coderabbitai bot reviewed Jan 3, 2025

View reviewed changes

coderabbitai bot approved these changes Jan 3, 2025

View reviewed changes

zds-s reviewed Jan 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

修复默认attachment翻页无效问题 #518

修复默认attachment翻页无效问题 #518

ljk123 commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

变更概览

步骤说明

变更

诗歌

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

zds-s Jan 3, 2025

ljk123 Jan 3, 2025

zds-s Jan 3, 2025

ljk123 Jan 3, 2025

修复默认attachment翻页无效问题 #518

Are you sure you want to change the base?

修复默认attachment翻页无效问题 #518

Conversation

ljk123 commented Jan 3, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jan 3, 2025 • edited Loading

变更概览

步骤说明

变更

诗歌

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

zds-s Jan 3, 2025

Choose a reason for hiding this comment

ljk123 Jan 3, 2025

Choose a reason for hiding this comment

zds-s Jan 3, 2025

Choose a reason for hiding this comment

ljk123 Jan 3, 2025

Choose a reason for hiding this comment

ljk123 commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading