Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table-and-menu): 去掉菜单新增和保存弹框,element plus 的el-tree-select 存在递归报错b… #511

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

kanyxmo
Copy link
Member

@kanyxmo kanyxmo commented Dec 25, 2024

…ug,所以去掉弹框。

  • 更新 mineadmin/table 到 1.0.33版本,修复 headerRender 多级表头中失效的bug

Summary by CodeRabbit

  • 新功能

    • 改进了菜单创建和保存的错误处理逻辑。
    • 优化了树节点展开的控制流程。
  • 依赖更新

    • 更新了 @mineadmin/table 依赖版本至 ^1.0.33
    • 更新了 element-plus 依赖版本至 ^2.9.1

…ug,所以去掉弹框。

- 更新 mineadmin/table 到 1.0.33版本,修复 headerRender  多级表头中失效的bug
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 25, 2024
Copy link

coderabbitai bot commented Dec 25, 2024

Warning

Rate limit exceeded

@dosubot[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f78b21b and 4a69bd8.

📒 Files selected for processing (2)
  • web/package.json (1 hunks)
  • web/src/modules/base/views/permission/menu/index.vue (2 hunks)
📝 Walkthrough

步骤概述

此拉取请求包含两个主要变更:一是在 web/package.json 中更新了两个依赖包的版本,二是修改了 web/src/modules/base/views/permission/menu/index.vue 文件中的错误处理和控制流逻辑。这些变更旨在优化代码健壮性和依赖管理。

变更

文件 变更摘要
web/package.json - @mineadmin/table 版本从 ^1.0.29 升级到 ^1.0.33
- element-plus 版本从 ^2.8.8 升级到 ^2.9.1
web/src/modules/base/views/permission/menu/index.vue - 移除 getMenu 中的 await nextTick
- 优化 setNodeExpand 函数的节点展开逻辑
- 简化 createOrSaveMenu 函数的错误处理

可能相关的 PR

建议标签

size:XS

诗歌

兔子轻跳依赖升级,
代码优化如春风起,
版本更迭无惊慌,
健壮逻辑展新意,
技术之路永不停。
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or PR title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kanyxmo kanyxmo merged commit 80ef288 into master Dec 25, 2024
13 of 23 checks passed
@dosubot dosubot bot added bug dependencies Pull requests that update a dependency file labels Dec 25, 2024
@zds-s zds-s deleted the fix(table-and-menu) branch December 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant