this is the first PR of WWZ team!#96
this is the first PR of WWZ team!#96Shmtu-Herven wants to merge 4 commits intomindspore-ai:masterfrom
Conversation
This is the first pr of WWZ team!!!
|
Welcome @Fengjuzhuwhw! |
|
Hi @Fengjuzhuwhw. Thanks for your PR. I'm waiting for a mindspore-ai member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
|
W00wssoooow!!! |
mindspore/numpy/dlpack.py
Outdated
| return PyCapsule_New(ctypes.byref(dl_managed_tensor), b'dltensor', None) | ||
|
|
||
| ## dlpack to numpy.array | ||
| def numpy_from_dlpack(pycapsule): |
There was a problem hiding this comment.
Please add from_dlpack(pycapsule) method to implement dlpack to mindspore.Tensor.
| from mindspore import Tensor | ||
| import numpy as np | ||
| def tensor_from_numpy(data_numpy): | ||
| return Tensor(data_numpy) |
There was a problem hiding this comment.
It would be better to have a check with the type data_numpy with the below:
if not isinstance(data_numpy, np.array):
panic()|
/ok-to-test |
|
Thinks a lot ! we will recheck it. |
this is the second PR of WZZ team!
|
this is the second PR of WZZ team! |
|
@Fengjuzhuwhw: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
What does this PR do / why do we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewers: