Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Typing #277

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Finish Typing #277

wants to merge 44 commits into from

Conversation

betaboon
Copy link
Contributor

@betaboon betaboon commented Dec 3, 2024

this PR builds on #276.

it adds remaining typing, configures mypy and marks the package as typed.

Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@coveralls
Copy link

Coverage Status

coverage: 97.261% (-1.4%) from 98.68%
when pulling 3dbbc4d on betaboon:typing
into 9cfad4c on mindflayer:main.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 97.261% (-1.4%) from 98.68%
when pulling 3dbbc4d on betaboon:typing
into 9cfad4c on mindflayer:main.

@coveralls
Copy link

Coverage Status

coverage: 97.261% (-1.4%) from 98.68%
when pulling 3dbbc4d on betaboon:typing
into 9cfad4c on mindflayer:main.

@mindflayer
Copy link
Owner

mindflayer commented Dec 5, 2024

Finding out what changed seems very difficult in here. It was already challenging with the previous PRs, I am finding it hard with these last two, and it's not even the first time I look at them.

@mindflayer
Copy link
Owner

I'm sorry, this went a "little" overboard 🙈

Now I fully understand your comment ^^

@betaboon
Copy link
Contributor Author

betaboon commented Dec 5, 2024

yep.
I'd suggest: let's ignore this PR for now, as it just builds on top of the other to finish up the typing.

let's use the other PR to discuss if and what we want to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants