Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce defaults in deps ingest pull request configuration #5226

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 19, 2024

Summary

If the user would forget to set the parameters, the deps ingest would
fail saying that the filter is invalid. This is not ideal for the user
since we should just set reasonable defaults.

This fixes that!

We now default to new_and_updated if no filter configuration is set.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

If the user would forget to set the parameters, the deps ingest would
fail saying that the filter is invalid. This is not ideal for the user
since we should just set reasonable defaults.

This fixes that!

We now default to `new_and_updated`  if no filter configuration is set.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner December 19, 2024 07:47
@coveralls
Copy link

Coverage Status

coverage: 55.1% (-0.01%) from 55.11%
when pulling 51e0fae on JAORMX:default-filters
into d80a187 on mindersec:main.

@JAORMX JAORMX merged commit 0068f4d into mindersec:main Dec 19, 2024
25 of 26 checks passed
@JAORMX JAORMX deleted the default-filters branch December 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants