Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually attempt to get the GitHub app's user ID #5214

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Actually attempt to get the GitHub app's user ID #5214

merged 1 commit into from
Dec 17, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 17, 2024

Summary

By giving an explicit name, we're actually able to get the app's user ID
as opposed to trying to get the ID of an app instance which results in a
403.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX
Actually attempt to get the GitHub app's user ID
c2a3274 
By giving an explicit name, we're actually able to get the app's user ID
as opposed to trying to get the ID of an app instance which results in a
403.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner December 17, 2024 11:10
@coveralls
Copy link

Coverage Status

coverage: 55.006% (+0.003%) from 55.003%
when pulling c2a3274 on JAORMX:app-user-id
into 4a53a45 on mindersec:main.

@JAORMX JAORMX merged commit 9286b31 into mindersec:main Dec 17, 2024
26 checks passed
@JAORMX JAORMX deleted the app-user-id branch December 17, 2024 11:43
eleftherias added a commit to eleftherias/minder that referenced this pull request Dec 17, 2024
@eleftherias
Revert "Actually attempt to get the GitHub app's user ID (mindersec#5214
aa1a687 
)"

This reverts commit 9286b31.
eleftherias added a commit that referenced this pull request Dec 17, 2024
@eleftherias
Revert "Actually attempt to get the GitHub app's user ID (#5214)" (#5217
ad7c2d2 
)

This reverts commit 9286b31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAORMX @coveralls @eleftherias