Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocks for provider interfaces #5211

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 17, 2024

Summary

This enables us to easily test pieces that use providers within minder.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This enables us to easily test pieces that use providers within minder.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner December 17, 2024 07:42
@coveralls
Copy link

Coverage Status

coverage: 55.364%. remained the same
when pulling 5fff62d on JAORMX:provider-mocks
into 24270ff on mindersec:main.

@JAORMX JAORMX merged commit 81d0096 into mindersec:main Dec 17, 2024
26 checks passed
@JAORMX JAORMX deleted the provider-mocks branch December 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants