Implement the Delete handler for the datasource service #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <[email protected]>
rdimitrov
force-pushed
the
delete-datasource
branch
from
5a9abd0 to
8e83409
Compare
JAORMX
reviewed
Nov 27, 2024
| defer func(stx serviceTX) { | ||
| err := stx.Rollback() | ||
| if err != nil { | ||
| fmt.Printf("failed to rollback transaction: %v", err) |
There was a problem hiding this comment.
let's not use fmt.Printf, you can build a zerologger from the context.Context instance.
... Aaaaaand I just realized I missed this in another review. @teodor-yanev can you submit a fix for the Create function?
There was a problem hiding this comment.
oh, hahaha, copy pasta! I can fix both here, thanks!
JAORMX
requested changes
Nov 27, 2024
Signed-off-by: Radoslav Dimitrov <[email protected]>
Great, I was in the process of writing the tests but opened the PR first to get the feedback, thanks! 👍 |
Signed-off-by: Radoslav Dimitrov <[email protected]>
teodor-yanev
approved these changes
Nov 27, 2024
JAORMX
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following PR implements the delete handler for the datasource service.
Fixes: #5045
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: