-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency ingester #5058
Dependency ingester #5058
Conversation
695cb43
to
fe2190d
Compare
This commit connects the components defined in the previous commits and fixes a panic when reading the configuration. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
fe2190d
to
97cd9af
Compare
return nil, fmt.Errorf("deps is only supported for repositories") | ||
} | ||
} | ||
func (gi *Deps) ingestRepository(ctx context.Context, repo *pb.Repository, params map[string]any) (*interfaces.Result, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
: I wonder if we could call the git
ingester directly from here and THEN process the result of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sgmt, I'll refactor it in follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, doesn't need to be in this PR
|
||
desiredCaps := scalibr_plugin.Capabilities{ | ||
OS: scalibr_plugin.OSLinux, | ||
Network: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do we need the network option for? We might wanna add a small comment for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to select the plugins that require network access. I'll add a note.
Summary
This PR finishes Evan's ingester started in #5030. It enables the dependency ingester using ov-scalibr. This allows us to write rules on the ingested protobom structs.
Here's the example ruletype I have been using to test:
Supersedes #5030
Change Type
Testing
Here's a simple profile to test:
Review Checklist: