fix(task-init): only skip init when saved state exists#734
Open
Wuodan wants to merge 1 commit intomindcraft-bots:developfrom
Open
fix(task-init): only skip init when saved state exists#734Wuodan wants to merge 1 commit intomindcraft-bots:developfrom
Wuodan wants to merge 1 commit intomindcraft-bots:developfrom
Conversation
Use `save_data` instead of `load_mem` when deciding whether to run `initBotTask()`. This fixes the case where `load_memory=true` but no saved bot state exists: the bot could skip task initialization and start without the configured task setup, such as initial inventory.
Contributor
Not sure if this is needed, I have used the |
Contributor
Author
|
When using a contruction task with an |
Contributor
You mean with Minecollab? I'll have to test it then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
save_datainstead ofload_memwhen deciding whether to runinitBotTask().This fixes the case where
load_memory=truebut no saved bot state exists: the bot could skip task initialization and start without the configured task setup, such as initial inventory.