Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Assessment - Angelo Reyes #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Frontend Assessment - Angelo Reyes #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions exercise-1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-EVSTQN3/azprG1Anm3QDgpJLIm9Nao0Yz1ztcQTwFspd3yD65VohhpuuCOmLASjC" crossorigin="anonymous">
<link rel="stylesheet" href="source/styles/css/exer1.css">
<title>Exercise 1 Frontend Assessment</title>
</head>
<body>
<header>
<section class="section section-banner">
<div class="container-fluid banner__container">
<div class="banner__body text-center w-100 d-flex">
<h1 class="banner__heading text-capitalize h1 font-weight-bold">hello developer!</h1>
<p class="banner__text font-weight-normal">Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p>
</div>
</div>
</section>
</header>

<section class="section section-content">
<div class="container content__container d-flex">
<div class="content__card card rounded-sm">
<img class="content__img card-img-top rounded-sm" src="http://via.placeholder.com/400x300" alt="a placeholder image">
<div class="card-body">
<p class="card-text text-center">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse urna nibh, finibus sit amet sapien gravida, dapibus viverra leo. In quis imperdiet elit. Fusce tempus massa lectus, ac sodales odio consectetur vitae. Nulla varius ante euismod tellus rhoncus fermentum. Mauris tristique orci justo, eu porttitor felis sollicitudin</p>
</div>
<a class="btn content__btn mx-auto rounded-pill" href="#" role="button">Read More</a>
</div>
<div class="content__card card rounded-sm">
<img class="content__img card-img-top rounded-sm" src="http://via.placeholder.com/400x300" alt="a placeholder image">
<div class="card-body">
<p class="card-text text-center">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam vehicula nisi nec lectus cursus vehicula.</p>
</div>
<a class="btn content__btn mx-auto rounded-pill" href="#" role="button">Read More</a>
</div>
<div class="content__card card rounded-sm">
<img class="content__img card-img-top rounded-sm" src="http://via.placeholder.com/400x300" alt="a placeholder image">
<div class="card-body">
<p class="card-text text-center">Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam vehicula nisi nec lectus cursus vehicula. Maecenas dui augue, malesuada vel justo ac, placerat porta ligula. Mauris vestibulum</p>
</div>
<a class="btn content__btn mx-auto rounded-pill" href="#" role="button">Read More</a>
</div>
</div>
</section>

<!-- scripts -->
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js" integrity="sha384-MrcW6ZMFYlzcLA8Nl+NtUVF0sA7MsXsP1UyJoMp4YLEuNSfAP+JcXn/tWtIaxVXM" crossorigin="anonymous"></script>
</body>
</html>
95 changes: 95 additions & 0 deletions exercise2.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
<!DOCTYPE html>
<htm lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta http-equiv="X-UA-Compatible" content="ie=edge" />
<title>Exercise 2 - Frontend Assessment</title>
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-EVSTQN3/azprG1Anm3QDgpJLIm9Nao0Yz1ztcQTwFspd3yD65VohhpuuCOmLASjC" crossorigin="anonymous">
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Open+Sans:wght@300;400;600;700&display=swap" rel="stylesheet">
<link rel="stylesheet" href="source/styles/css/exer2.css">
</head>
</html>
<body>
<header>
<section class="section section-tabs my-4">
<div class="container-fluid d-flex p-0">
<div class="nav nav-tabs flex-column" id="tabData" role="tablist">
</div>
<div class="tab-content d-flex p-2" id="TabContent">
<div class="tab-pane fade show active" id="tab0" role="tabpanel" aria-labelledby="tab-0"></div>
<div class="tab-pane fade" id="tab1" role="tabpanel" aria-labelledby="tab-1"></div>
<div class="tab-pane fade" id="tab2" role="tabpanel" aria-labelledby="tab-2"></div>
<div class="tab-pane fade" id="tab3" role="tabpanel" aria-labelledby="tab-3"></div>
</div>
</div>
</section>

<div class="accordion" id="accordionMobile">
<div class="accordion-item">
<button id="collapseButton0" class="accordion-button" type="button" data-bs-toggle="collapse" data-bs-target="#collapse0" aria-expanded="true" aria-controls="collapseZero">

</button>

<div id="collapse0" class="accordion-collapse collapse show " aria-labelledby="collapseZero" data-bs-parent="#accordionMobile">
<div id="collapseValue0" class="accordion-body">

</div>
</div>
</div>
<div class="accordion-item">
<button id="collapseButton1" class="accordion-button collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#collapse1" aria-expanded="false" aria-controls="collapseOne">

</button>

<div id="collapse1" class="accordion-collapse collapse" aria-labelledby="collapseOne" data-bs-parent="#accordionMobile">
<div id="collapseValue1" class="accordion-body">

</div>
</div>
</div>
<div class="accordion-item">
<button id="collapseButton2" class="accordion-button collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#collapse2" aria-expanded="false" aria-controls="collapseTwo">

</button>

<div id="collapse2" class="accordion-collapse collapse" aria-labelledby="collapseTwo" data-bs-parent="#accordionMobile">
<div id="collapseValue2" class="accordion-body">

</div>
</div>
</div>
<div class="accordion-item">
<button id="collapseButton3" class="accordion-button collapsed" type="button" data-bs-toggle="collapse" data-bs-target="#collapse3" aria-expanded="false" aria-controls="collapseThree">

</button>

<div id="collapse3" class="accordion-collapse collapse" aria-labelledby="collapseThree" data-bs-parent="#accordionMobile">
<div id="collapseValue3" class="accordion-body">

</div>
</div>
</div>
</div>
</header>
<section class="section section-bonus my-4">
<div class="container d-flex flex-column">
<p class="bonus__question texts-center mx-auto p-4">
Why does <strong class="bonus--yellow">('b' + 'a' + + 'a' + 'a').toLowerCase()</strong> resolve to <strong class="text-warning">banana?</strong>
</p>
<ul class="list-group rounded-3">
<li class="list-group-item"><strong class="text-warning">'b' + 'a'</strong> returns ba, this is regular concatenation.</li>
<li class="list-group-item"><strong class="text-warning">ba + + 'a'</strong> attempts to concatenate ba with <strong class="text-warning">+ 'a'.</strong> However, since the <strong class="text-warning">unary operator + </strong>attempts to convert its operand into a number, the value <strong class="text-warning">NaN</strong> is returned, which is then converted into a string when concatenated with the original <strong class="text-warning">ba -</strong> thus resulting in <strong class="text-warning">baNaN.</strong></li>
<li class="list-group-item"><strong class="text-warning">baNaN + 'a'</strong> returns <strong class="text-warning">baNaNa.</strong> Again, this is regular concatenation.</li>
<li class="list-group-item">At this stage, the result from step one is <strong class="text-warning">baNaNa</strong>.</li>
<li class="list-group-item">Applying <strong class="text-warning">.toLowerCase() </strong>on the value returned from step one gives: <strong class="text-warning">banana</strong></li>

</ul>
</div>
</section>
</body>
<script type="text/javascript" src="source/scripts/script.js"></script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js" integrity="sha384-MrcW6ZMFYlzcLA8Nl+NtUVF0sA7MsXsP1UyJoMp4YLEuNSfAP+JcXn/tWtIaxVXM" crossorigin="anonymous"></script>
</html>
42 changes: 8 additions & 34 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,14 @@
Introduction
---
Thanks for taking the time to complete this frontend technical assessment. We will be focusing on software quality (scalability, readability, maintainability, etc.) and your eye for detail. You may include any libraries, but Vue.js is preferred and jQuery is not recommended. Along with following best practices, bonus points for following our [coding guidelines](https://github.com/mindarc/frontend-assessment/wiki/Coding-guidelines).
Hi, thank you for evaluating my submission! I wanted to keep it as simple and vanilla as possible. Hope it helps with your assessment of my capabilities.

Exercise 1
---
Build a responsive page based on the designs.

##### Requirements
1. Match the designs exactly.
2. Needs to be responsive.
##### Exercise 1
* Fully responsive design matching the provided images namely:
1. exercise1-desktop.png
2. exercise1-mobile.png

##### Designs
* exercise1-desktop.png
* exercise1-mobile.png
##### Exercise 2
* display data from data.json file using tabs (for desktop) and accordion (for mobile) with custom design and styling.
* bonus 'banana' question

##### Assets
* Desktop banner - http://via.placeholder.com/1920x650
* Mobile banner - http://via.placeholder.com/600x600
* Content images - http://via.placeholder.com/400x300

Exercise 2
---
Read the `data.json` file and display the data as tabs on desktop and an accordion on mobile.

##### Requirements
1. Display data in tabs on desktop.
2. Display data in an accordion on mobile.
3. Only 1 accordion/tab should be open at a time.
4. Open the first accordion/tab on load.
5. If the open accordion is selected, close it.

###### Bonus points
* Improve the user experience with meaningful animations/transitions.
* Design and styling.
* Explain why the result of `('b' + 'a' + + 'a' + 'a').toLowerCase()` is `banana`.

Submission
---
We recommend submitting your completed assessment as a forked repository. Please replace README content with instructions and relevant documentation.
50 changes: 50 additions & 0 deletions source/scripts/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
window.onresize = () => { window.location.reload()}
const mediaQuery = window.matchMedia('(min-width: 576px)');

fetch('https://raw.githubusercontent.com/mindarc/frontend-assessment/master/data.json')
.then(function (response) {
return response.json();
})
.then(function (data) {
appendData(data);
})
.catch(function (err) {
});
function appendData(data) {
if (mediaQuery.matches) {
let tabContainer = document.getElementById("tabData");
for (let i = 0; i < data.length; i++) {
let tabBtn = document.createElement("button");
let tabValue = document.getElementById("tab"+i)
Element.prototype.setAttributes = function(tabBtn){
for(let prop in tabBtn) {
this.setAttribute(prop, tabBtn[prop])
}
}
Element.prototype.setAttributes = function(tabBtn){
for (let prop in tabBtn) { this.setAttribute(prop, tabBtn[prop]) }
}
if (i == 0) {
tabBtn.setAttributes({"class": "nav-link active tab--active my-1 py-2", "data-bs-toggle": "tab", "data-bs-target": "#tab" + i,"type": "button", "role": "tab"})
}
else {
tabBtn.setAttributes({"class": "nav-link my-1 py-2", "data-bs-toggle": "tab", "data-bs-target": "#tab" + i,"type": "button", "role": "tab"})
}
tabBtn.innerHTML = data[i].title;
tabValue.innerHTML = data[i].content;
tabContainer.appendChild(tabBtn);
}

}
else {

for (let i = 0; i < data.length; i++) {
let accordionValue = document.getElementById("collapseValue"+i)
let accordionTitle = document.getElementById("collapseButton"+i);
// let accordionValue = document.getElementById("");
accordionTitle.innerHTML = data[i].title;
accordionValue.innerHTML = data[i].content;

}
}
}
123 changes: 123 additions & 0 deletions source/styles/css/exer1.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
.section-banner {
background-image: linear-gradient(to bottom, rgba(0, 0, 0, 0.3), rgba(0, 0, 0, .3)), url("http://via.placeholder.com/1920x650");
background-size: cover;
background-repeat: no-repeat;
background-position: center;
height: 650px;
}

.banner__container {
height: 100%;

}
.banner__body {
height: 100%;
color: #fff;
justify-content: center;
align-items: center;
flex-direction: column;
letter-spacing: .2em;
}
.banner__heading {
font-weight: bold;
font-size: 3.5em;
}
.banner__text {
font-weight: normal;
font-size: 2em;

}

.section-content {
padding: 3em 0;
}

.content__container {
justify-content: space-around;
align-items: center;
flex-flow: wrap;
}

.content__card {
padding: 1em;
flex-basis: 30%;
height: 600px;
}

.content__img {
object-fit: contain;
}

.card-text {
font-size: 1em;
font-weight: 500;
}

.content__btn {
border: solid 2px #000;
font-weight: bold;
width: fit-content;
text-transform: uppercase;
letter-spacing: .1em;
}
.content__btn:hover {
background: #000;
color: #fff;
}



/* tablet responsiveness */
@media screen and (max-width: 991px) {
.card-text {
font-size: .85em;
}

.content__container {
max-width: 100%;
padding: 1em;
}
}

@media screen and (max-width: 767px) {
.section-content {
padding: 2em 0;
}

.content__card {
margin: 1.5em 0;
flex-basis: 75%;
height: unset;
}
}

/* mobile responsiveness */
@media screen and (max-width: 575px) {
.section-banner {
background-image: linear-gradient(to bottom, rgba(0, 0, 0, 0.3), rgba(0, 0, 0, .3)), url("http://via.placeholder.com/600x600");
height: unset;
padding: 4em 0;
}

.content__container {
padding: 1em;
}

.content__card {
flex-basis: 100%;
}
}

@media screen and (max-width: 320px) {
.banner__heading {
font-weight: bold;
font-size: 2.75em;
}

.banner__text {
font-weight: normal;
font-size: 1.75em;

}
}

Loading