test(vault-registry): add lifecycle event payload regression tests - #767
Merged
manoahLinks merged 1 commit intoAug 31, 2026
Merged
Conversation
Add focused regression tests that verify exact event payloads for the set_listed lifecycle transition (Listed ↔ Delisted). These tests lock down the current behavior without changing production code. Tests added: - lifecycle_event_set_listed_delist_payload: verifies (true, false) payload when transitioning Listed → Delisted - lifecycle_event_set_listed_relist_payload: verifies (false, true) payload when transitioning Delisted → Listed Both tests verify exact event topic, resource ID, and payload structure. Related to: Add lifecycle transition event payload tests Scope: contract/contracts/vault-registry/
|
@coderolisa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #623
Add focused regression tests that verify exact event payloads for the set_listed lifecycle transition (Listed ↔ Delisted). These tests lock down the current behavior without changing production code.
Tests added:
Both tests verify exact event topic, resource ID, and payload structure.
Related to: Add lifecycle transition event payload tests
Scope: contract/contracts/vault-registry/
Checklist
feat:,fix:,chore:, etc.)pnpm build:server/pnpm --filter @mindvault/web build)pnpm test)pnpm contract:test).envis gitignored; use.env.examplefor placeholders)