Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FontARA could get stuck after a temporary startup failure, accept stale UI snapshots or match lookalike hosts. Release retries also depended on expiring CI artifacts and coupled Firefox publishing to Chrome's outcome. This change fixes those failure modes and makes development and release checks enforceable.
Validation:
pnpm verifypasses (517 unit + 95 inject tests, coverage, all builds, package lint, version checks, dependency audits and reproducible ZIPs); 63 Chrome browser cases, all 7 Firefox cases and both production-package installation checks pass. One local Firefox session-creation failure passed on focused rerun. Native SBOM generation is byte-identical across runs. Actionlint and whitespace checks pass. Runtime regressions fail against the original implementation and pass with these fixes.CodeQL review fixed all 11 actionable initial alerts, then hardened descriptor-based input reads and regex escaping for three additional PR findings. The 167 initial false positives and five PR false positives were individually reviewed and dismissed with recorded explanations; no blanket query suppression was introduced. The latest PR scan confirms zero open findings. Symlink/path-replacement regressions pass.
Hosted CI also exposed a performance-fixture readiness issue before any workload metrics were collected. The test now waits for runtime/content readiness, foreground visibility and initial font application before measuring; performance budgets remain unchanged. All 22 focused release security tests and the focused real Chrome performance check pass.
Historical contribution triage: incorporate the applicable return type from #156 and Edge installation documentation from #115. #108/#107/#85 overlap current icon protection and variable-font/swap behavior. #87/#75/#3 target the removed pre-v4 architecture and should be closed as superseded rather than merged into the current extension. No new store version is submitted by this PR; post-merge checks exercise live attestation and authenticated read-only store status.