Skip to content

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Sep 1, 2025

See also: #2909

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed approved labels Sep 1, 2025
@mergify mergify bot added the dco-passed label Sep 1, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 15.94203% with 58 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@2f3216f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/milvus_client/async_milvus_client.py 0.00% 48 Missing ⚠️
pymilvus/milvus_client/milvus_client.py 44.44% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2968   +/-   ##
=========================================
  Coverage          ?   50.10%           
=========================================
  Files             ?       63           
  Lines             ?    12474           
  Branches          ?        0           
=========================================
  Hits              ?     6250           
  Misses            ?     6224           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Sep 1, 2025
@XuanYang-cn XuanYang-cn added PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch and removed PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x labels Sep 2, 2025
@XuanYang-cn XuanYang-cn force-pushed the remove-logs-in-milvusclient branch from 565fed6 to 1762426 Compare September 9, 2025 07:45
@XuanYang-cn XuanYang-cn changed the title enhance: Require return types for public methods enhance: Remove all annoying logs in MilvusClient Sep 9, 2025
Signed-off-by: yangxuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants