fix(cli): increase runtime trace finalization timeout to 60s - #1753
Open
skoshx wants to merge 1 commit into
Open
fix(cli): increase runtime trace finalization timeout to 60s#1753skoshx wants to merge 1 commit into
skoshx wants to merge 1 commit into
Conversation
Chrome needs more time to finalize large performance traces, especially for longer recording sessions (up to 5 minutes). The previous 10-second timeout was insufficient for complex React applications generating substantial trace data. Increased timeout from 10s to 60s, which: - Aligns with industry best practices for CDP trace finalization - Accommodates traces from the max 5-minute recording duration - Prevents spurious timeouts on large/complex applications Also improved the error message to be more actionable. Closes #1752 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1752 — Chrome did not finish the performance trace in time.
Root Cause
The 10-second timeout for Chrome's
Tracing.tracingCompleteevent was insufficient for large performance traces, especially from longer recording sessions (up to 5 minutes) on complex React applications.When Chrome finishes a performance recording:
Tracing.endis called to stop recordingTracing.tracingCompleteeventFix
Increased
RUNTIME_SCAN_TRACING_COMPLETE_TIMEOUT_MSfrom 10s to 60s, which:Also improved the error message to be more actionable, guiding users to record shorter interactions if the timeout still occurs.
Scope
This is a narrow, targeted fix:
Testing
Changeset
Patch release — fixes a runtime error, no API changes.