Skip to content

fix notify_channel for AsyncRpcBase #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix notify_channel for AsyncRpcBase #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bde9b9
fix notify_channel for AsyncRpcBase
Aug 31, 2021
3e779fc
Handle sending on closed socket
Nov 24, 2023
df77bbf
Merge pull request #1 from maciejpankanin/master
mczerski Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions channels_jsonrpc/jsonrpcconsumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ def error(_id, code, message, data=None):
def notify_channel(self, method, params):
"""
Notify a group. Using JSON-RPC notificatons
:param reply_channel: Reply channel
:param method: JSON-RPC method
:param params: parmas of the method
:return:
Expand Down Expand Up @@ -328,10 +327,30 @@ def _base_receive_json(self, content):

# Send response back only if it is a call, not notification
if not is_notification:
self.send_json(result)
try:
self.send_json(result)
except Exception as e:
# The only thing we know can fail here is sending to a closed
# socket, so just log it. Sadly at this point we have
# to except so broadly because actual exception type depends
# on what ASGI server we're running on.
logger.warning(
"Could not send JSON response back to user on socket: %s",
e,
)


class AsyncRpcBase(RpcBase):
async def notify_channel(self, method, params):
"""
Notify a group. Using JSON-RPC notificatons
:param method: JSON-RPC method
:param params: parmas of the method
:return:
"""
content = self.json_rpc_frame(method=method, params=params)
await self.send(await self.encode_json(content))

async def __get_result(self, method, params):

func_args = getattr(getfullargspec(method), keywords_args)
Expand Down Expand Up @@ -424,7 +443,17 @@ async def _base_receive_json(self, content):

# Send response back only if it is a call, not notification
if not is_notification:
await self.send_json(result)
try:
await self.send_json(result)
except Exception as e:
# The only thing we know can fail here is sending to a closed
# socket, so just log it. Sadly at this point we have
# to except so broadly because actual exception type depends
# on what ASGI server we're running on.
logger.warning(
"Could not send JSON response back to user on socket: %s",
e,
)


class JsonRpcWebsocketConsumer(JsonWebsocketConsumer, RpcBase):
Expand Down