You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move @elizaOS package pins to the available alpha dist-tag and record the Bun lockfile, including the Rollup WASM override used by local Vite builds.
Replace the desktop preflight chain with a tolerant optional-check wrapper, skip absent postinstall bridge patch scripts, and restore the top-level production build wrapper.
Stub server-only elizaOS runtime imports in the app Vite build so renderer bundles do not pull native API-side modules.
Note
Restore Milady install and build entrypoints with Node 22+ validation and plugin stubbing
run-production-build.mjs now resolves a Node.js 22+ binary at runtime (skipping macOS Codex-bundled Node), falls back to Bun, and forwards MILADY_REPO_ROOT and CLI args to the downstream build script
vite.config.ts stubs any @elizaos/plugin-* bare import and any path under /packages/agent/src/ as virtual modules during browser bundling, replacing the previous explicit plugin list; also adds stubs for registerJsRuntimeFactory and readWorkspaceFolderConfig
Move @elizaOS package pins to the available alpha dist-tag and record the Bun lockfile, including the Rollup WASM override used by local Vite builds.
Replace the desktop preflight chain with a tolerant optional-check wrapper, skip absent postinstall bridge patch scripts, and restore the top-level production build wrapper.
Stub server-only elizaOS runtime imports in the app Vite build so renderer bundles do not pull native API-side modules.
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Restores and hardens Milady’s install/build entrypoints by repinning elizaOS packages to the available alpha dist-tag, reintroducing a top-level production build wrapper, making desktop preflight checks tolerant of missing scripts, and expanding Vite stubbing so renderer bundles don’t pull server-only elizaOS runtime modules.
Changes:
Replaced the chained dev:desktop:preflight script with a new wrapper that skips missing optional checks.
Added a top-level scripts/run-production-build.mjs wrapper delegating into @elizaos/app-core.
Updated @elizaos/* dependency pins to alpha, added a Rollup WASM override, and extended Vite’s native-module stubbing for server-only imports.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File
Description
scripts/run-production-build.mjs
Restores a production build entrypoint delegating to app-core.
scripts/milady-postinstall-repo-setup.mjs
Skips missing Milady bridge patch scripts instead of hard-failing postinstall.
scripts/dev-desktop-preflight.mjs
New tolerant preflight runner for optional desktop checks.
package.json
Switches desktop preflight to wrapper, repins elizaOS deps to alpha, and adds Rollup WASM override.
apps/homepage/package.json
Repins homepage elizaOS deps to alpha.
apps/app/vite.config.ts
Expands renderer stubbing for server-only elizaOS/agent/plugin imports and adds missing export shims.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR successfully transitions dependencies to alpha tags and introduces scripts intended to improve the developer experience on Windows and production build reliability. However, several critical areas require attention before merging:
The new scripts scripts/dev-desktop-preflight.mjs and scripts/run-production-build.mjs show an increase in logic complexity but lack any unit or integration tests to verify their resilience.
The Vite configuration's nativeModuleStubPlugin uses global, context-unaware regex patterns to detect exports. This approach is brittle and could lead to broken builds if exports are formatted across multiple lines or if identifiers appear within comments.
There are minor consistency issues with Windows path normalization in the Vite plugin logic.
About this PR
The mechanism for avoiding duplicate export injections in the Vite transform phase is context-unaware. Reliance on simple regex for code transformation can fail on multi-line exports or code containing documentation comments that mirror export names.
The new logic in 'dev-desktop-preflight.mjs' and 'run-production-build.mjs' lacks unit or integration tests. Given these scripts are meant to handle environment-specific edge cases, automated verification is recommended to prevent regressions during future updates.
Test suggestions
Verify that dev-desktop-preflight.mjs correctly identifies and skips non-existent scripts without throwing errors.
Verify that run-production-build.mjs correctly sets MILADY_REPO_ROOT and delegates to the app-core build script.
Test Vite nativeModuleStubPlugin's path normalization to ensure it correctly stubs paths containing Windows backslashes.
Confirm that the Vite transform regex 'directExport' correctly detects existing 'export const/function' declarations to avoid duplicate stubs.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that dev-desktop-preflight.mjs correctly identifies and skips non-existent scripts without throwing errors.
2. Verify that run-production-build.mjs correctly sets MILADY_REPO_ROOT and delegates to the app-core build script.
3. Test Vite nativeModuleStubPlugin's path normalization to ensure it correctly stubs paths containing Windows backslashes.
4. Confirm that the Vite transform regex 'directExport' correctly detects existing 'export const/function' declarations to avoid duplicate stubs.
Include the new desktop preflight and production build wrappers in the published files allowlist.
Normalize the agent subpath check before matching and rely on the @elizaos/plugin-* catch-all instead of duplicate explicit plugin entries.
Point the root build script at scripts/run-production-build.mjs so package-mode CI uses the Milady wrapper instead of invoking the app-core script directly with a stale Node executable path.
Re-add the root script aliases consumed by the Electrobun release workflows, including test:regression-matrix:release-contract and the release contract/e2e package checks.
Keep heavy-only e2e paths explicitly excluded from the default e2e command and included in test:e2e:heavy so validate-regression-matrix passes.
Split the generated logger shim payload out of ensureLoggerShimPackage, remove nested template-string content from the shim source, and scope the dynamic write helper to the known shim directory.
Replace the generated @elizaos/logger string payload with a tracked shim package under scripts/shims. The alignment script now links that package directly, avoiding the oversized helper, generated template strings, and dynamic file writes Codacy reported.
Keep the @elizaos/logger compatibility shim as vendored code and point CI alignment at vendor/elizaos-logger. This avoids Codacy treating the shim declaration files as normal scripts while preserving the local package link needed for eliza refs that import @elizaos/logger.
Resolve a standard Node runtime before spawning build children and fall back to Bun when only the Codex-bundled macOS Node is visible. This prevents Rolldown native bindings from loading under the signed Codex Node while keeping fresh Bun-only developer installs buildable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
category:feature
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Move @elizaOS package pins to the available alpha dist-tag and record the Bun lockfile, including the Rollup WASM override used by local Vite builds.
Replace the desktop preflight chain with a tolerant optional-check wrapper, skip absent postinstall bridge patch scripts, and restore the top-level production build wrapper.
Stub server-only elizaOS runtime imports in the app Vite build so renderer bundles do not pull native API-side modules.
Note
Restore Milady install and build entrypoints with Node 22+ validation and plugin stubbing
MILADY_REPO_ROOTand CLI args to the downstream build script@elizaos/plugin-*bare import and any path under/packages/agent/src/as virtual modules during browser bundling, replacing the previous explicit plugin list; also adds stubs forregisterJsRuntimeFactoryandreadWorkspaceFolderConfigpackage.jsonand apppackage.jsonfiles switch@elizaos/*dependencies frombeta/pinned versions to thealphatag@elizaos/*deps toalphameans any breaking alpha release will affect installs immediatelyMacroscope summarized ba530fe.