-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MILAB-685] Smart cache new #8
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7ab845c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from minor comments, all looks good for me. But we need to test it in real blocks.
* | ||
* @param fn: func() - the hook that should be executed before the end of the body. | ||
*/ | ||
registerOnBodyEnd: func(fn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it be executed if thee is an exception inside the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I guess if any error happens the whole rendered block will become unusable, so I don't think it's too important.
Also, it seems like a good addition, but how to add this? We probably can add it in the workflow's controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it guaranteed that there will be no memory leak? The data stored in KV (for use in cache) will be cleared ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, pl-core will delete KV along with the resource
No description provided.