Fix bug squid installation on stratum1

[ahmam]

Add variable to make choose to configure squid in stratum 1 or not.

[btravouillon]

Has this bug been reported to upstream project and acknowledged?

[milaflq]

@ahmam
Add variable cvmfs_strqtum1_squid

Est-ce un typo? (cvmfs_strqtum1_squid)

[milaflq]

Sinon, le code est bon de mon point de vue.

[ahmam]

Has this bug been reported to upstream project and acknowledged?

it is not reported to upstream because it is really optional it is a feature that we need but I will report it in a pull request.

[btravouillon]

it is not reported to upstream because it is really optional it is a feature that we need but I will report it in a pull request.

Looks like package squid is also added in upstream PR that you mentionned in #3. Looking further, the squid package is installed on the stratum1 without condition for RHEL-like hosts (https://github.com/galaxyproject/ansible-cvmfs/blob/0.2.21/vars/redhat.yml#L19). Thus I believe you can just add the package, you don't have to introduce any new variable that would change the behaviour of the role for RHEL-like hosts.

[ahmam]

it is not reported to upstream because it is really optional it is a feature that we need but I will report it in a pull request.

Looks like package squid is also added in upstream PR that you mentionned in #3. Looking further, the squid package is installed on the stratum1 without condition for RHEL-like hosts (https://github.com/galaxyproject/ansible-cvmfs/blob/0.2.21/vars/redhat.yml#L19). Thus I believe you can just add the package, you don't have to introduce any new variable that would change the behaviour of the role for RHEL-like hosts.

I just added the package squid to comply with redhat and remove the changes made by the variable.

[btravouillon]

Looks good to me. 👍