-
-
Notifications
You must be signed in to change notification settings - Fork 94
Case insensitive tokens #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 6 commits
649aacd
6e842c1
df4f7d4
99c0b13
68fb37a
206cd6b
d0c99e1
eb49874
9830f08
23afdac
8144f94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -32,13 +32,15 @@ class Session < ApplicationRecord | |||||||||||||||
| # hashed version in the database | ||||||||||||||||
| attr_reader :token | ||||||||||||||||
|
|
||||||||||||||||
| def token=(plaintext) | ||||||||||||||||
| self.token_digest = Passwordless.digest(plaintext) | ||||||||||||||||
| @token = (plaintext) | ||||||||||||||||
| def token=(token) | ||||||||||||||||
| Passwordless.config.case_insensitive_tokens ? modified_token = token.upcase : modified_token = token | ||||||||||||||||
| self.token_digest = Passwordless.digest(modified_token) | ||||||||||||||||
| @token = (modified_token) | ||||||||||||||||
|
||||||||||||||||
| def token=(token) | |
| Passwordless.config.case_insensitive_tokens ? modified_token = token.upcase : modified_token = token | |
| self.token_digest = Passwordless.digest(modified_token) | |
| @token = (modified_token) | |
| def token=(plaintext) | |
| self.token_digest = Passwordless.digest(plaintext) | |
| @token = (plaintext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to do this at write time - we're persisting the token digest, not the token, so I believe we cannot upcase the token digest when searching for tokens.
Uh oh!
There was an error while loading. Please reload this page.