Skip to content

Effect is a keyword in ocaml 5.3 #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Effect is a keyword in ocaml 5.3 #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/boot/lib/deadcode.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ let tm_has_side_effect nmap tm =
if acc_se then (true, acc_prerun)
else
match SymbMap.find_opt s nmap with
| Some (_, _, effect, _) ->
(effect, acc_prerun)
| Some (_, _, side_effect, _) ->
(side_effect, acc_prerun)
| None ->
(false, acc_prerun) (* In case of lambda or pattern variables *)
)
Expand Down
4 changes: 2 additions & 2 deletions src/boot/lib/mexpr.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,14 +664,14 @@ let getData = function
, [] )
| _, _ ->
failwith "bootparser getData undefined" )
| PTreeTop (TopExt (Ext (fi, str, effect, ty))) ->
| PTreeTop (TopExt (Ext (fi, str, side_effect, ty))) ->
( idDeclExt
, [fi]
, []
, [ty]
, []
, [str]
, [(if effect then 1 else 0)]
, [(if side_effect then 1 else 0)]
, []
, []
, []
Expand Down
Loading