Authenticate/Inviting #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehonoshin
reviewed
Sep 6, 2019
|
|
||
| private | ||
|
|
||
| def authorize! |
There was a problem hiding this comment.
зачем свою писать, если есть sorcery или devise?
Remove authenticate with jwt-token and adding authenticate with devise gem
Mehonoshin
suggested changes
Sep 8, 2019
app/controllers/home_controller.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class HomeController < ApplicationController | |||
| before_action :authorize! | |||
| before_action :authenticate_user! | |||
There was a problem hiding this comment.
это имеет смысл перенести в application_controller
|
|
||
| # GET /invite | ||
| def invite | ||
| User.invite!(email: '[email protected]', fullname: 'John Doe') |
There was a problem hiding this comment.
Из-за того, что логики пока никакой нет.
config/initializers/devise.rb
Outdated
| # Many of these configuration options can be set straight in your model. | ||
| Devise.setup do |config| | ||
| config.invite_for = 1.weeks | ||
| # The secret key used by Devise. Devise uses this key to generate |
There was a problem hiding this comment.
все эти комментарии имеет смысл вычистить
| class CreateUsers < ActiveRecord::Migration[5.2] | ||
| def change | ||
| create_table :users do |t| | ||
| t.string :fullname |
There was a problem hiding this comment.
Сам всегда ограничения стараюсь ставить. Сегодня воскресенье)
| ## Rememberable | ||
| t.datetime :remember_created_at | ||
|
|
||
| ## Trackable |
| before_action :authenticate_user! | ||
|
|
||
| # GET /invite | ||
| def invite |
There was a problem hiding this comment.
такое название метода не по REST.
И судя по всему оно меняет стейт в базе, поэтому надо юзать POST #create
Mehonoshin
reviewed
Sep 8, 2019
| class CreateUsers < ActiveRecord::Migration[5.2] | ||
| def change | ||
| create_table :users do |t| | ||
| t.string :fullname, null: false, default: '' |
There was a problem hiding this comment.
я думаю default тут не нужен, откуда возьмется юзер без имени?
db/seeds.rb
Outdated
| # | ||
| # movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) | ||
| # Character.create(name: 'Luke', movie: movies.first) | ||
| User.create(email: '[email protected]', |
spec/factories/user.rb
Outdated
| @@ -0,0 +1,6 @@ | |||
| FactoryBot.define do | |||
| factory :user do | |||
| email { '[email protected]' } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил аутентификацию с помощью JWT.
Аутентификация
#POST /loginПараметры
email- почтаpassword- парольПример ответа
Отправляем инвайт
# GET /send_inviteЗаголовки
AuthorizationПример ответа
Создаем пользователя
# POST /usersПараметры
email- почтаpassword- парольПример ответа