Work for SOLPS->Hermes-3 interpolation: radial/poloidal data overhaul#6
Open
mikekryjak wants to merge 44 commits into
Open
Work for SOLPS->Hermes-3 interpolation: radial/poloidal data overhaul#6mikekryjak wants to merge 44 commits into
mikekryjak wants to merge 44 commits into
Conversation
SOLPS may not reach exactly the same grid extents as Hermes-3. These SOL rings must be left unfilled and then extrapolated later.
Can take specific poloidal index, reads psi, has docstring
Now does interpolation over psi instead of a fraction of the radial distance. This is now in line with Hermes-3 and should be more accurate.
Tool can now take an arbitrary radial start region to define sepdist. This is useful e.g. for getting PFR data, where sepdist should be defined at the target.
Avoids using -1 as a selector. Ensures all custom sol ring selections are included.
Need to implement guard replacement properly. THis hack made coords inconsistent.
This causes issues because theres no poloidal index corresponding to this
Now plotted in black/yellow instead of try/excepting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b2fgmtrywhich includes psi and other useful arrays.